use the UMF version from git describe in tests, not the harcoded one #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_umf_ver_workflow
branch
2 times, most recently
from
3975310 to
cb3abf0
Compare
lukaszstolarczuk
requested changes
Jan 7, 2025
Contributor
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
pls update RELEASE_STEPS.md
beside that, LGTM
bratpiorka
force-pushed
the
rrudnick_umf_ver_workflow
branch
from
cb3abf0 to
d28e1c9
Compare
Contributor
|
och, also, you could fix the commit msg (and the title of the PR), to something more meaningful |
bratpiorka
force-pushed
the
rrudnick_umf_ver_workflow
branch
from
d28e1c9 to
0b4cbaa
Compare
bratpiorka
changed the title
Contributor
Author
better? if not, please suggest something |
PatKamin
approved these changes
Jan 8, 2025
ldorau
approved these changes
Jan 8, 2025
lukaszstolarczuk
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the UMF version from git describe in tests, not the harcoded one
fixes #1025